Proxito: do not serve non-existent versions

Avoid serving files that are still in the storage (S3) for some reason but its
associated version was deleted or de-activated.

Closes readthedocs/readthedocs-ops#1139

Author: humitos

readthedocs/proxito/tests/test_full.py

@@ -198,6 +198,25 @@ def test_external_version_serving_old_slugs(self):
 
     # Invalid tests
 
+    def test_non_existent_version(self):
+        url = "/en/non-existent-version/"
+        host = "project.dev.readthedocs.io"
+        resp = self.client.get(url, HTTP_HOST=host)
+        self.assertEqual(resp.status_code, 404)
+
+    def test_inactive_version(self):
+        url = "/en/inactive/"
+        host = "project.dev.readthedocs.io"
+        fixture.get(
+            Version,
+            verbose_name="inactive",
+            slug="inactive",
+            active=False,
+            project=self.project,
+        )
+        resp = self.client.get(url, HTTP_HOST=host)
+        self.assertEqual(resp.status_code, 404)
+
     @override_settings(
         RTD_EXTERNAL_VERSION_DOMAIN='dev.readthedocs.build',
     )

readthedocs/proxito/views/serve.py

@@ -84,13 +84,19 @@ def get(self,
             version_slug=version_slug,
             filename=filename,
         )
-
-        # All public versions can be cached.
         version = final_project.versions.filter(slug=version_slug).first()
+
+        # Skip serving versions that don't exist or are not active. This is to
+        # avoid serving files that we have in the storage, but its associated
+        # version does not exist anymore or it was de-activated
+        if not version or not version.active:
+            raise Http404("Version does not exist or is not active.")
+
         if (
             self._is_cache_enabled(final_project)
             and version and not version.is_private
         ):
+            # All public versions can be cached.
             self.cache_request = True
 
         log.bind(