Reduce verbose logging on generic command failure #8904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We updated the copy used for generic errors with the celery refactor, but also converted a generic command failure to `BuildUserError(msg)`. This caused the command output to always be used as the error message shown to the user. More error classes is probably the direction we want to go here, perhaps even going as far as to provide more helpful errors for each step that commonly emits the generic user error class.
|
Untested locally, working on that now. |
humitos
reviewed
Feb 8, 2022
humitos
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the copy used for generic errors with the celery refactor,
but also converted a generic command failure to
BuildUserError(msg).This caused the command output to always be used as the error message
shown to the user.
More error classes is probably the direction we want to go here, perhaps
even going as far as to provide more helpful errors for each step that
commonly emits the generic user error class.
Refs #8901