File tree 1 file changed +8
-11
lines changed
1 file changed +8
-11
lines changed Original file line number Diff line number Diff line change @@ -444,24 +444,21 @@ def run_command_class(
444
444
self .commands .append (build_cmd )
445
445
446
446
if build_cmd .failed :
447
- msg = 'Command {cmd} failed' .format (cmd = build_cmd .get_command ())
448
-
449
- # TODO: improve this error report. This is showing _the full_
450
- # stdout to the user exposing it at the top of the Build Detail's
451
- # page in red. It would be good to reduce the noise here and just
452
- # point the user to take a look at its output from the command's
453
- # output itself.
454
- if build_cmd .output :
455
- msg += ':\n {out}' .format (out = build_cmd .output )
456
-
457
447
if warn_only :
448
+ msg = 'Command {cmd} failed' .format (cmd = build_cmd .get_command ())
449
+ if build_cmd .output :
450
+ msg += ':\n {out}' .format (out = build_cmd .output )
458
451
log .warning (
459
452
msg ,
460
453
project_slug = self .project .slug if self .project else '' ,
461
454
version_slug = self .version .slug if self .version else '' ,
462
455
)
463
456
else :
464
- raise BuildUserError (msg )
457
+ # TODO: for now, this still outputs a generic error message
458
+ # that is the same across all commands. We could improve this
459
+ # with more granular error messages that vary by the command
460
+ # being run.
461
+ raise BuildUserError ()
465
462
return build_cmd
466
463
467
464
You can’t perform that action at this time.
0 commit comments