-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Log conda version and docker image hash when creating a container. #8755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I'm requesting changes because we need to run the command inside the Docker container. We can't use subprocess.run
for this unfortunately.
version = subprocess.run( | ||
["conda", "--version"], | ||
capture_output=True, | ||
text=True, | ||
check=True, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using Docker in our build process, so this command won't work. We need to execute the conda --version
inside the Docker container where the build is taking place. I remember there are other places in the code where we execute a command to get the Sphinx's version (I think) from where you can copy the idea to get the conda's version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment @humitos. I am dealing with my finals now. Would that be okay if a take a look at it in the next week?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 👍🏼
Hi @dogukanteber ! Some tests are still failing: |
Hello @astrojuanlu. Yes, I have finished my finals. I have not realized some tests failed. I did some changes but it did not work. Right now, I am stuck. I cannot find a way out. Do you have any recommendations on how should I proceed? |
The tests fail now with |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Thanks for the PR. This can now be accomplished with https://docs.readthedocs.io/en/latest/config-file/v2.html#build-jobs |
This PR hopefully resolves #8375 . I have written a small method to get the conda version but I also saw venv_path in the Conda class which is located in python_environment.py. I could not decide if it returns the conda version. If it is more appropriate, I can remove the method I wrote and change it with the existing one.