Skip to content

Logging: log conda version and docker image hash #8375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
astrojuanlu opened this issue Jul 27, 2021 · 2 comments
Closed
1 of 2 tasks

Logging: log conda version and docker image hash #8375

astrojuanlu opened this issue Jul 27, 2021 · 2 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@astrojuanlu
Copy link
Contributor

astrojuanlu commented Jul 27, 2021

While testing #8328, I found a couple of things that could be logged to improve observability:

  • Log conda version, if used
  • Log Docker image hash, apart from stable, latest, or testing
@humitos
Copy link
Member

humitos commented Jul 27, 2021

Just adding some context here. We are logging the image= and the id= in

log.info(
'Creating Docker container: image=%s id=%s',
self.container_image,
self.container_id,
)

We should probably update that line to add these other values.

@humitos humitos added Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code labels Jul 27, 2021
@humitos humitos self-assigned this Jan 27, 2022
@humitos humitos changed the title Logging improvements Logging: log conda and docker image hash Mar 15, 2022
@humitos humitos changed the title Logging: log conda and docker image hash Logging: log conda version and docker image hash Mar 15, 2022
@humitos
Copy link
Member

humitos commented Jul 6, 2022

We are already logging the output of the conda --version command into the BuildData model.

@humitos humitos closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants