Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation names cleanup #8586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation names cleanup #8586
Changes from 5 commits
2ac4b25
76dd278
082fdbc
c3502bb
71e8ad8
e3e330a
767fbbd
ebba17a
4d0704e
937faa5
8419e1e
77ac082
573cbad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #8573 (comment) you said
but GitHub calls these "Webhooks" (see https://github.com/readthedocs/readthedocs.org/settings/hooks), not "Integrations"
Anyways, I don't think we need to revert any of this work (at least now it makes sense under RTD itself), but I just want to mention that "Integration" is not a good name IMO and we should eventually stop using it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are indeed webhooks, from the github side (you create a webhook to subscribe to github events). Then you have integrations https://github.com/readthedocs/readthedocs.org/settings/installations, that's services that subscribe to those events (that's what rtd does)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well... Nope. If that's the case, we would be an "Integration" once we migrate to GitHub Application. --which is not the case, now.