Skip to content

Clarify webhook and integration documentation #8573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astrojuanlu opened this issue Oct 11, 2021 · 6 comments · Fixed by #8586
Closed

Clarify webhook and integration documentation #8573

astrojuanlu opened this issue Oct 11, 2021 · 6 comments · Fixed by #8586
Labels
Needed: design decision A core team decision is required

Comments

@astrojuanlu
Copy link
Contributor

Coming from #8522:

So, in our docs we have a webhooks page...

Seeking some feedback on the terminology here. We could:

  • Rename /webhooks.html to /integrations.html
  • Replace Incoming Webhooks and Automation by Integrations and Automation,
  • And use the term "integration" rather than "webhook" throughout the page, unless it refers to a UI option.

This would be more consistent with the UI. However, each of these individual integrations is still called "incoming webhook":

image

Therefore, for full consistency, probably we should rename "incoming webhook" to just "integration". I just checked that this is what GitHub and MailerLite do.

What do folks think?

And then, after renaming /webhooks.html, would it be wise to repurpose the URL for outgoing webhooks? Otherwise, we would keep them at https://docs.readthedocs.io/en/stable/build-notifications.html#using-webhook, including the upcoming new features introduced at #8522.

cc @readthedocs/advocacy @readthedocs/backend

@astrojuanlu astrojuanlu added the Needed: design decision A core team decision is required label Oct 11, 2021
@ericholscher
Copy link
Member

Agreed here. I tried to figure out our GH webhook docs the other day and they're super confusing. Definitely lots of room for improvement here, outside of renaming.

@stsewd
Copy link
Member

stsewd commented Oct 11, 2021

And then, after renaming /webhooks.html, would it be wise to repurpose the URL for outgoing webhooks?

We would need to create a redirect from webhooks.html to integrations.html, so, we can't re-use that page that easily (or maybe it's fine, and having a note about the old page being moved).

Also, I think the title could be just Integrations or VCS Integrations (dropping the "automation" part, as that page doesn't include anything extra).

@astrojuanlu
Copy link
Contributor Author

We used VCS Integrations for this guide https://docs.readthedocs.io/en/stable/guides/vcs.html which might benefit from a renaming as well...?

@ericholscher
Copy link
Member

@astrojuanlu Definitely feel free to do a larger rename/refactor here. Lots of naming debt, so make a proposal 👍

@humitos
Copy link
Member

humitos commented Oct 13, 2021

I'd avoid using "Integrations" unless we provide something else than a webhook. When using "webhook" is clear that we will send/receive a request with data, nothing else. On the other hand, "integration" conveys a lot more work done between the parts involved in the integration. An example of integration to me are GitHub Applications and/or Slack Applications.

@astrojuanlu
Copy link
Contributor Author

I get what you say, but the advantages of renaming it to "integrations" are:

  • It is forward compatible with non-webhook integrations. We may or may not have this in the short term, but doesn't harm getting used to it I think.
  • We avoid confusion with outgoing webhooks
  • We are consistent with the UI menus (there's an "integrations" link and header in the settings)
  • We are consistent with other products

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants