-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Clarify webhook and integration documentation #8573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Agreed here. I tried to figure out our GH webhook docs the other day and they're super confusing. Definitely lots of room for improvement here, outside of renaming. |
We would need to create a redirect from webhooks.html to integrations.html, so, we can't re-use that page that easily (or maybe it's fine, and having a note about the old page being moved). Also, I think the title could be just |
We used |
@astrojuanlu Definitely feel free to do a larger rename/refactor here. Lots of naming debt, so make a proposal 👍 |
I'd avoid using "Integrations" unless we provide something else than a webhook. When using "webhook" is clear that we will send/receive a request with data, nothing else. On the other hand, "integration" conveys a lot more work done between the parts involved in the integration. An example of integration to me are GitHub Applications and/or Slack Applications. |
I get what you say, but the advantages of renaming it to "integrations" are:
|
Coming from #8522:
Seeking some feedback on the terminology here. We could:
/webhooks.html
to/integrations.html
Incoming Webhooks and Automation
byIntegrations and Automation
,This would be more consistent with the UI. However, each of these individual integrations is still called "incoming webhook":
Therefore, for full consistency, probably we should rename "incoming webhook" to just "integration". I just checked that this is what GitHub and MailerLite do.
What do folks think?
And then, after renaming
/webhooks.html
, would it be wise to repurpose the URL for outgoing webhooks? Otherwise, we would keep them at https://docs.readthedocs.io/en/stable/build-notifications.html#using-webhook, including the upcoming new features introduced at #8522.cc @readthedocs/advocacy @readthedocs/backend
The text was updated successfully, but these errors were encountered: