Remove some feature flags

[stsewd]

These features have been enabled on a large sample for a while now, and I also enabled them in all projects since last last week (~12 days ago).

The only problem found was with Sphinx itself #7816, but iit's all good now.
We use the subscription to decide if page views should be enabled in .com.

[humitos]

Looks good to me!

[humitos]

Is this method overwritten in commercial taking into account the plan?

[stsewd]

yep

[lpsinger]

In this PR, the change from calling sphinx-build to calling python -m sphinx build broke my project: https://readthedocs.org/projects/gwcelery/builds/

[stsewd]

@lpsinger from the build log, this looks like more a problem with your dependencies.

ModuleNotFoundError: No module named 'ligo'

Or are you able to replicate this locally in a clean environment? Like changing from calling sphinx-build to python -m sphinx

[lpsinger]

Yes, I can replicate this in a clean environment. Changing sphinx-build to python -m sphinx breaks my build.

I narrowed it down to this by diffing the last successful build log and the first unsuccessful one.

[humitos]

I think it's because it's reading ligo package from the folder ligo/ even without being installed when using sphinx-build.

You need to install your project on Read the Docs using https://docs.readthedocs.io/en/stable/config-file/v2.html#python

python:
  install:
    - method: pip
      path: .

[stsewd]

you can also inject the absolute path in sys.path https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#module-sphinx.ext.autodoc

[lpsinger]

You need to install your project on Read the Docs using https://docs.readthedocs.io/en/stable/config-file/v2.html#python

Why do I need to install my project? I didn't need to install it before. I was mocking up all of the dependencies that are not actually used for generating docs and figures.

[stsewd]

I think this is a problem with the implicit cwd

https://git.ligo.org/emfollow/gwcelery/-/blob/master/doc/conf.py#L26

you should use _file_ to resolve the absolute path to the current file instead of depending on the cwd.

[lpsinger]

I think this is a problem with the implicit cwd

https://git.ligo.org/emfollow/gwcelery/-/blob/master/doc/conf.py#L26

you should use _file_ to resolve the absolute path to the current file instead of depending on the cwd.

That work. Thanks!

[lpsinger]

Wait, no, that didn't work. Same error message as before.

[lpsinger]

I've been staring at this all day, and I can't figure out how to work around it. Is it possible to revert this please? Otherwise we will have to stop using Readthedocs for hosting our documentation.

[lpsinger]

Never mind! I found what was wrong: only my long term memory. I forgot that I had put in place some code to detect whether my modules were being imported under Sphinx, which I had failed to update... https://git.ligo.org/emfollow/gwcelery/-/commit/c9ab81b5d33718df7e8991752938e009e643a8f0

[humitos]

@lpsinger I'm happy that you figured it out!