Skip to content

Sphinx-1.8.5 is used even if newer Sphinx installed #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tk0miya opened this issue Jan 9, 2021 · 4 comments
Closed

Sphinx-1.8.5 is used even if newer Sphinx installed #7816

tk0miya opened this issue Jan 9, 2021 · 4 comments
Labels
Bug A bug

Comments

@tk0miya
Copy link

tk0miya commented Jan 9, 2021

Details

Thank you for hosting the greatest service! Now I got trouble with the version of Sphinx.
Sphinx-1.8.5 has been used to build our document even if newer Sphinx is installed.
This trouble has been started since Jan 7th. Before that, the expected version of Sphinx had been used.

refs: sphinx-doc/sphinx#8662

Expected Result

The newer version is used to build the document. In my understanding, the newer version of Sphinx was installed on the before step via setup.py install --force command.
(I confirmed the expected version was used at Jan 6th: https://readthedocs.org/projects/sphinx/builds/12705105/)

Actual Result

The default version Sphinx-1.8.5 is used.

@stsewd
Copy link
Member

stsewd commented Jan 11, 2021

Hi, thanks for reporting, this is because we activated this flag

def get_sphinx_cmd(self):
if self.project.has_feature(Feature.FORCE_SPHINX_FROM_VENV):
return (
self.python_env.venv_bin(filename='python'),
'-m',
'sphinx',
)
return (
'python',
self.python_env.venv_bin(filename='sphinx-build'),
)

For some reason sphinx-build uses the newest installed version, but python -m sphinx uses the old one. I have disabled the feature for now, we'll need to investigate what's happening before enabling it again.

@stsewd stsewd added the Bug A bug label Jan 11, 2021
@stsewd
Copy link
Member

stsewd commented Jan 11, 2021

I think maybe because setup.py install doesn't remove the old one? Maybe using pip install will solve this. You'll need to use a config file for that, I have commented how to use it here sphinx-doc/sphinx#8666

@tk0miya
Copy link
Author

tk0miya commented Jan 16, 2021

Thank you for disabling it. Now I added a configuration file. It's okay to enable it again. I suppose this is a trouble only for sphinx project.

@stsewd
Copy link
Member

stsewd commented Jan 18, 2021

I have enabled the feature again, looks like using pip fixed the problem https://readthedocs.org/projects/sphinx/builds/12793774/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants