Revert "Revert ES: update dependencies" #7439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 26f7b3c.
agjohnson
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
So, after some discussion, this seems safe. The change was already reviewed prior, but this is the revert of upgrading our search API results. We backed this out because there were users using the old search API directly. It sounds like most users that we were waiting on have now migrated, so it's safe to upgrade the API again. Because of the way we provide search API results, there is not a clear path for deprecation unfortunately.
I don't have a lot of background here, and am not best to review elasticsearch-dsl changes, so I'm relying on previous review for the technical changes.
|
Yep, I think we're 👍 here. We should be safer going forward with a documented and abstracted search API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7429
We can merge this together with #7414 since the old endpoint is going to change, better to just get rid of it in the process.