Skip to content

Grab the correct name of RemoteOrganization to use in the query #7430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 8, 2020
Merged

Grab the correct name of RemoteOrganization to use in the query #7430

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
27e5943
Grab the correct name of RemoteOrganization to use in the query
humitos Sep 1, 2020
3effd6d
Refactor VCS sync code to return RemoteRepository and RemoteOrganization
humitos Sep 2, 2020
e267f66
Exclude `None` values from repositories and organizations
humitos Sep 2, 2020
4b75df6
Lint
humitos Sep 2, 2020
c49478e
Tests for GitHubService sync operations
humitos Sep 2, 2020
12d0a52
Grab the correct name of RemoteOrganization to use in the query
humitos Sep 1, 2020
08314b1
Merge branch 'humitos/sync-orgs-github' of github.com:readthedocs/rea…
humitos Sep 8, 2020
3016828
Use organization.slug to delete the organizations
humitos Sep 8, 2020
1bd7cfe
Merge branch 'master' of github.com:readthedocs/readthedocs.org into …
humitos Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions readthedocs/oauth/services/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def sync_repositories(self):

def sync_organizations(self):
"""Sync organizations from GitHub API."""
orgs = []
orgs_details = []
repositories = []

try:
Expand All @@ -66,6 +66,9 @@ def sync_organizations(self):
'{org_url}/repos'.format(org_url=org['url']),
)

# Add organization details to the result
orgs_details.extend(org_resp.json())

# Add all the repositories for this organization to the result
repositories.extend(org_repos)

Expand All @@ -79,7 +82,7 @@ def sync_organizations(self):
'try reconnecting your account'
)

return orgs, repositories
return orgs_details, repositories

def create_repository(self, fields, privacy=None, organization=None):
"""
Expand Down