Grab the correct name of RemoteOrganization to use in the query #7430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the naked response from GitHub to exclude `RemoteOrganization` objects and delete the ones where the user don't have permissions anymore. However, we need the organization details instead that comes with the `name` attribute which is the one that we use to create the `RemoteOrganization` object.
ericholscher
reviewed
Sep 1, 2020
Instead of returning a list of dictionaries with different structure, we are returning a list of RemoteRepository and RemoteOrganization. Then, we use the same field names (`full_name` and `name`) from the objects we are going to filter by the old values to be removed. This reduces the complexity of choosing the right field for each service from the dictionary previously returned; avoiding picking the wrong field, returning `None` and removing all the Remote* objects for that user.
- `sync_repositories` creates RemoteRepository from API - `sync_organizations` creates RemoteOrganization from API - `sync` removes stale RemoteRepository and RemoteOrganization - do not remove RemoteRepository if linked to a Project - do not remove RemoteRepository where the user still have permissions
stsewd
reviewed
Sep 3, 2020
| @@ -25,3 +25,5 @@ pytest-mock==3.3.0 | |||
| # local debugging tools | |||
| datadiff==2.0.0 | |||
| ipdb==0.13.3 | |||
|
|
|||
| requests-mock==1.8.0 | |||
There was a problem hiding this comment.
Note: now we can remove this dep from .com
stsewd
approved these changes
Sep 3, 2020
We were using the naked response from GitHub to exclude `RemoteOrganization` objects and delete the ones where the user don't have permissions anymore. However, we need the organization details instead that comes with the `name` attribute which is the one that we use to create the `RemoteOrganization` object.
stsewd
force-pushed
the
humitos/sync-orgs-github
branch
from
c49478e to
12d0a52
Compare
|
This looks good once we fix the conflict. 👍 |
…dthedocs.org into humitos/sync-orgs-github
`name` is not mandatory and some organization does not have it. That's why we were deleting some valid organizations.
…humitos/sync-orgs-github
|
@stsewd be careful with force-push next time. You deleted a commit that added some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the naked response from GitHub to excludeRemoteOrganizationobjects and delete the ones where the user don't have permissions anymore.However, we need the organization details instead that comes with thenameattribute which is the one that we use to create theRemoteOrganizationobject.I refactored this code to always return a list of
RemoteRepositoryandRemoteOrganizationfrom thesync_repositoriesandsync_organizationsmethods on each service to avoid using the wrong field name, as we were doing.Closes #7381