Sync RemoteRepository and RemoteOrganization in all VCS providers #7310
Conversation
- Refactor `Service.sync` to be unique for all the VCS providers - Make `sync_repositories` and `sync_organizations` to return `repositories` and `(organizations, repositories)` to allow deleting old instances where the user does not have more access - rename `BitBucketService.sync_teams` to `BitBucketService.sync_organizations` to keep our internal naming With this commit, all VCS providers (GitHub, GitLab and BitBucket) will start deleting old RemoteRepository instances (not only GitHub as it's currently working) but also deleting old RemoteOrganization instances as well.
When fetching repositories and organizations always return a valid list. If the user does not have repositories or organizations, a empty list is returned. This allows the code to continue working properly in the further steps.
| repos = self.sync_repositories() | ||
| organizations, organization_repos = self.sync_organizations() | ||
|
|
||
| # Delete RemoteRepository where the user doesn't have access anymore |
There was a problem hiding this comment.
I wonder if we should run these delete tasks across all users as a one-time CLI command, to clean up our DB. There's likely a ton of these sitting around.
There was a problem hiding this comment.
This one-time command would require to sync all VCS account connected and delete all the old objects. That may be too much. We may want to limit the amount of accounts re-synced and run it several times by chunks. It will remove a lot of stale data.
However, as this cleanup is in the core of the sync action, all active accounts will be cleanup automatically when they login next time or, when they click the arrow from Import Project page.
|
I'm going to merge this since it's useful as is it. We can keep the conversation about re-sync all the accounts and make a final decision, tho. |
Service.syncto be unique for all the VCS providerssync_repositoriesandsync_organizationsto returnrepositoriesand
(organizations, repositories)to allow deleting old instances where theuser does not have more access
BitBucketService.sync_teamstoBitBucketService.sync_organizationsto keep our internal naming
With this commit, all VCS providers (GitHub, GitLab and BitBucket) will start
deleting old RemoteRepository instances (not only GitHub as it's currently
working) but also deleting old RemoteOrganization instances as well.
This is a step previous to #2759 and it's required for GitLab/BitBucket VCS SSO
Closes #2412