Force to use proxied API for footer and search #6768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,6 @@ class DockerBaseSettings(CommunityDevSettings): | |||
| PRODUCTION_DOMAIN = 'community.dev.readthedocs.io' | |||
| PUBLIC_DOMAIN = 'community.dev.readthedocs.io' | |||
| PUBLIC_API_URL = f'http://{PRODUCTION_DOMAIN}' | |||
| RTD_PROXIED_API_URL = PUBLIC_API_URL | |||
There was a problem hiding this comment.
Shouldn't we keep the setting, to make it easier for users to override? I think supporting the setting is fine, I just want a default that is _/ as we have now.
There was a problem hiding this comment.
We had that setting to pass it down to context during build time. But we want to apply this change to everyone. So, not sure if we can have both.
stsewd
added a commit
to readthedocs/readthedocs-sphinx-ext
that referenced
this pull request
Mar 17, 2020
This reverts #77 Ref readthedocs/readthedocs.org#6768
ericholscher
approved these changes
Apr 16, 2020
|
This needs to regenerate the static js files, I wasn't able to do it with my node setup for now... I'll try later. |
I was able to run npm now, turns out js files are already up to date, tested it locally to confirm too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts:
And force the use of the proxied api to all docs.
This wasn't done before because .com wasn't ready.
Note for users using a custom installation and not using subdomains, you'll need to edit these files to point to your main domain.