Change the default of proxied_api_host to api_host #6355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to respec the ``api_host`` that might be configured in pre-built documentation. Previously these would all default to ``readthedocs.org``, which isn't great for local dev or custom installs.
stsewd
reviewed
Nov 7, 2019
stsewd
reviewed
Nov 7, 2019
stsewd
approved these changes
Nov 7, 2019
Co-Authored-By: Santos Gallegos <[email protected]>
Co-Authored-By: Santos Gallegos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to respect the
api_hostthat might be configuredin pre-built documentation.
Previously these would all default to
readthedocs.org,which isn't great for local dev or custom installs.