Don't assume build isn't None in a docker build env #6599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kind of the same we hit with a local env readthedocs#6503
stsewd
commented
Jan 29, 2020
agjohnson
reviewed
Jan 29, 2020
stsewd
force-pushed
the
dont-asume-build-on-docker-env
branch
from
2af1906 to
e024beb
Compare
agjohnson
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Don't assume build isn't None in a docker build env This is kind of the same we hit with a local env #6503 * Check for self.build * Use context manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of the same we hit with a local env
#6503