Don't pass build to environment when doing a sync #6503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't record this step, so we don't have a `build`
We default project, version and build to None, but in some parts we assume there aren't None.
ericholscher
approved these changes
Jan 8, 2020
stsewd
added a commit
to stsewd/readthedocs.org
that referenced
this pull request
Jan 28, 2020
This is kind of the same we hit with a local env readthedocs#6503
agjohnson
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Don't assume build isn't None in a docker build env This is kind of the same we hit with a local env #6503 * Check for self.build * Use context manager
agjohnson
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Don't assume build isn't None in a docker build env This is kind of the same we hit with a local env #6503 * Check for self.build * Use context manager
humitos
pushed a commit
that referenced
this pull request
Jan 29, 2020
This is kind of the same we hit with a local env #6503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't record this step, so we don't have a
buildAlso, added protection against None. We default project, version and build to None,
but in some parts we assume there aren't None.