Skip to content

Fix eslint #6317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ language: python
python:
- 3.6
dist: xenial

env:
global:
- NODE_VERSION=10.17.0

matrix:
include:
- python: 3.6
Expand All @@ -27,8 +32,8 @@ install:
- pip install tox-travis
- curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.2/install.sh | bash
- source ~/.nvm/nvm.sh
- nvm install --lts
- nvm use --lts
- nvm install $NODE_VERSION
- nvm use $NODE_VERSION
- npm install -g bower
- npm install
- bower install
Expand Down
4 changes: 2 additions & 2 deletions docs/development/front-end.rst
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ in.
Getting Started
---------------

You will need a working version of Node and NPM to get started. We won't cover
that here, as it varies from platform to platform.
You will need a working version of Node (tested with ``v10.17.0``) and NPM to get started.
We won't cover that here, as it varies from platform to platform.

To install these tools and dependencies::

Expand Down
2 changes: 1 addition & 1 deletion docs/development/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -183,4 +183,4 @@ see :doc:`buildenvironments`.
For building this documentation,
see :doc:`docs`.

And for setting up for the front end development, see :doc:`standards`.
And for setting up for the front end development, see :doc:`front-end`.
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ commands =
--die-on-tool-error {posargs}

[testenv:eslint]
whitelist_externals = npm
description = run the JavaScript linter (requires `npm install`)
commands =
npm run lint
Expand Down