Skip to content

Fix eslint #6317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 25, 2019
Merged

Fix eslint #6317

merged 6 commits into from
Oct 25, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 21, 2019

I just rebuilt the js assets.

@stsewd
Copy link
Member Author

stsewd commented Oct 21, 2019

pinning the node version worked! :)

@stsewd stsewd requested a review from a team October 21, 2019 22:44
humitos
humitos reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

I don't have a strong opinion here because I don't have too much experience.

It seems the current LTS version is v12.x. Was that the problem? Why it does not build with the latest LTS version?

@stsewd
Copy link
Member Author

stsewd commented Oct 22, 2019

It seems the current LTS version is v12.x. Was that the problem? Why it does not build with the latest LTS version?

That's the problem the linter is given, guess they updated the lts version.

@stsewd
Copy link
Member Author

stsewd commented Oct 22, 2019

yup, they updated the LTS version from v10 to v12 https://nodejs.org/en/download/releases/ a couple of days ago

@stsewd stsewd mentioned this pull request Oct 22, 2019
Merged
agjohnson
agjohnson requested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! I don't think we should have JS changes added here though. What changed here to generate new JS?

@stsewd
Copy link
Member Author

stsewd commented Oct 23, 2019

What changed here to generate new JS?

Nothing I guess, just built them to make sure we have the latest files.

@stsewd
Copy link
Member Author

stsewd commented Oct 23, 2019

@agjohnson js files are omited now

@stsewd stsewd requested a review from agjohnson October 23, 2019 17:17
@agjohnson
Copy link
Contributor

There is something that happens here, and it's hard to tell if anything even changed in the built assets. In my environment, I always generate new assets, different from everyone else. I had to have David do the build steps on last release because my environment was re-creating all the assets -- his didn't recreate anything 😕

agjohnson
agjohnson reviewed Oct 24, 2019
View reviewed changes
@stsewd stsewd requested a review from agjohnson October 24, 2019 17:27
@agjohnson agjohnson merged commit f5dbf2c into readthedocs:master Oct 25, 2019
@stsewd stsewd deleted the fix-eslint branch October 25, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stsewd @agjohnson @humitos