-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Allow only post requests for delete views #6242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
{% blocktrans trimmed %} | ||
This version is inactive but its documentation is still available online. | ||
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely. | ||
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using this here because using a button here doesn't look good also it breaks lot of CSS styles. Would love to get some Suggestions. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a suggestion for this, and also this is something that users shouldn't hit that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense for now.
I'd appreciate if you add this comment into the template itself (using {# #}
) so we know why this done in this way in the future. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humitos Added comment.
Thanks, can you attach some screenshots of the final result? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
{% blocktrans trimmed %} | ||
This version is inactive but its documentation is still available online. | ||
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely. | ||
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a suggestion for this, and also this is something that users shouldn't hit that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just left a comment to add a comment in the template.
{% blocktrans trimmed %} | ||
This version is inactive but its documentation is still available online. | ||
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely. | ||
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense for now.
I'd appreciate if you add this comment into the template itself (using {# #}
) so we know why this done in this way in the future. Thanks!
closes: #6189