Skip to content

Only use post for delete actions #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Sep 17, 2019 · 1 comment · Fixed by #6242
Closed

Only use post for delete actions #6189

stsewd opened this issue Sep 17, 2019 · 1 comment · Fixed by #6242
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Sep 17, 2019

While refactoring some views I realized that we are allowing get actions to delete some models/relations.

Some of them:

This should be done after those PRs are merged
@stsewd stsewd added Good First Issue Good for new contributors Status: blocked Issue is blocked on another issue labels Sep 17, 2019
This was referenced Oct 2, 2019
Merged
Merged
@stsewd stsewd added the Improvement Minor improvement to code label Oct 2, 2019
@stsewd
Copy link
Member Author

stsewd commented Oct 2, 2019

This is unblocked, anyone feel free to take this issue

@stsewd stsewd removed the Status: blocked Issue is blocked on another issue label Oct 2, 2019
@saadmk11 saadmk11 mentioned this issue Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow only post requests for delete views saadmk11/readthedocs.org
1 participant
@stsewd