Skip to content

Add Better error message for lists in config file #6200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2019
Merged

Add Better error message for lists in config file #6200

merged 4 commits into from
Oct 9, 2019

Conversation

saadmk11
Copy link
Member

closes #4914

@saadmk11 saadmk11 requested review from stsewd and a team September 21, 2019 16:43
stsewd
stsewd reviewed Sep 23, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move this to a method, something like get_display_key. And then we should need to add a test for the value of the str(exc)

@saadmk11 saadmk11 requested a review from stsewd September 24, 2019 18:20
stsewd
stsewd reviewed Sep 24, 2019
View reviewed changes
@saadmk11 saadmk11 requested a review from stsewd September 25, 2019 13:46
stsewd
stsewd approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. Only one suggestion around the static method.

@humitos humitos merged commit 8fd1fe3 into readthedocs:master Oct 9, 2019
@saadmk11 saadmk11 deleted the better-error-msg branch October 9, 2019 14:39
stsewd added a commit to readthedocs/test-builds that referenced this pull request Nov 12, 2019
@stsewd
Test readthedocs/readthedocs.org#6200
cd88865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better errror message for lists in config file
3 participants
@saadmk11 @humitos @stsewd