Skip to content

Better errror message for lists in config file #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Nov 19, 2018 · 5 comments · Fixed by #6200
Closed

Better errror message for lists in config file #4914

stsewd opened this issue Nov 19, 2018 · 5 comments · Fixed by #6200
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Nov 19, 2018

After #4740 is merged, we will show the error message for lists as list.{index}, which isn't so clear, we should use list[{index}] instead.

Raised in #4740 (comment)

@stsewd stsewd added this to the Refactoring milestone Nov 19, 2018
@stsewd stsewd added the Improvement Minor improvement to code label Nov 19, 2018
@dojutsu-user
Copy link
Member

@stsewd
Can I take this issue?

@stsewd
Copy link
Member Author

stsewd commented Nov 19, 2018

No yet, it depends on #4740, in we should think in a way of resolve this #4740 (comment)

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Status: blocked Issue is blocked on another issue and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
@stsewd stsewd added Needed: design decision A core team decision is required and removed Status: blocked Issue is blocked on another issue labels Mar 1, 2019
@stsewd
Copy link
Member Author

stsewd commented Mar 1, 2019

This isn't blocker anymore, but we still need to figure out a clean way of implementing this.

And I'm not really sure adding that logic is worth it, we should just keep the current message.

@humitos
Copy link
Member

humitos commented May 23, 2019

we still need to figure out a clean way of implementing this.

This will take care the person that implements it.

I'm removing the Design decision label and marking it as Accepted.

And I'm not really sure adding that logic is worth it, we should just keep the current message.

We can decide that when we see the changes in the PR propsed.

@humitos humitos added Accepted Accepted issue on our roadmap and removed Needed: design decision A core team decision is required labels May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants