Refactor views projects #6171
Merged
Refactor views projects #6171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Sep 30, 2019
| @@ -111,38 +111,53 @@ def get_context_data(self, **kwargs): | |||
| return context | |||
|
|
|||
|
|
|||
| class ProjectUpdate(ProjectSpamMixin, PrivateViewMixin, UpdateView): | |||
| class ProjectMixin(PrivateViewMixin): | |||
There was a problem hiding this comment.
Just with the name of the class, I'm not 100% sure if all the Project views need to inherit from this class or not. I guess, yes. Although, it may be good to reflect what the mixin is about in the name of the class, or if that's tricky, in a docstring.
There was a problem hiding this comment.
All of them inherit this mixin but ProjectDasboard, because it's very different, it doesn't share anything in common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from a function view to a class based view, and also putting some common pieces under a base class.
Ref #5856