Skip to content

Refactor view to class based views that use auth mixins #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agjohnson opened this issue Jun 27, 2019 · 1 comment · Fixed by #6272
Closed

Refactor view to class based views that use auth mixins #5856

agjohnson opened this issue Jun 27, 2019 · 1 comment · Fixed by #6272
Labels
Accepted Accepted issue on our roadmap

Comments

@agjohnson
Copy link
Contributor

Instead of using one-off and disparate methods for authorization, views should be refactored to use CBV and authentication mixins that already exist, such as AuthMixin. This will reduce the number of ways that we're performing authentication and make our authorization more unified.
@agjohnson agjohnson added the Accepted Accepted issue on our roadmap label Jun 27, 2019
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Sep 11, 2019
@stsewd
Clean up views
f4ad289 
Some general cleanup.

Related readthedocs#5856
This was referenced Sep 11, 2019
Merged
Merged
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Sep 12, 2019
@stsewd
Refactor views ProjectVersion
d9ab73f 
Ref readthedocs#5856
@stsewd stsewd mentioned this issue Sep 12, 2019
Merged
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Sep 12, 2019
@stsewd
Refactor views ProjectUsers
e2aedb6 
Ref readthedocs#5856
@stsewd stsewd mentioned this issue Sep 12, 2019
Merged
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Sep 16, 2019
@stsewd
Refactor ProjectNotications views
2723dc8 
Ref readthedocs#5856
@stsewd stsewd mentioned this issue Sep 16, 2019
Merged
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Sep 16, 2019
@stsewd
Refactor ProjectTranslations views
60b2c60 
ref readthedocs#5856
@stsewd stsewd mentioned this issue Sep 16, 2019
Merged
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Sep 16, 2019
@stsewd
Refactor ProjectRedirects views
f10607f 
ref readthedocs#5856
@stsewd stsewd mentioned this issue Sep 16, 2019
Merged
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Sep 17, 2019
@stsewd
Refactor SearchAnalytics view
41d4768 
ref readthedocs#5856
@stsewd stsewd mentioned this issue Sep 17, 2019
Merged
@stsewd
Copy link
Member

stsewd commented Oct 8, 2019

Only these are left

https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/profiles/views.py

https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/gold/views.py

The other ones are public views

@saadmk11 saadmk11 mentioned this issue Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Gold Views saadmk11/readthedocs.org
2 participants
@agjohnson @stsewd