Skip to content

Do not show wipe version message on build details page for External versions #6034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Aug 2, 2019

We should not show wipe version message on the build details page for external versions as we disabled wipe version functionality for external versions.

def wipe_version(request, project_slug, version_slug):
version = get_object_or_404(
Version.internal.all(),
project__slug=project_slug,
slug=version_slug,
)

@saadmk11 saadmk11 requested review from ericholscher and a team August 2, 2019 09:15
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I wonder if this should check something more explicit, like build.supports_wipe that we can just add that logic in one place?

@saadmk11
Copy link
Member Author

saadmk11 commented Aug 6, 2019

Yeah we can do that :)

@saadmk11
Copy link
Member Author

saadmk11 commented Aug 7, 2019

@ericholscher Updated the PR.

@saadmk11 saadmk11 requested a review from ericholscher August 7, 2019 09:29
@ericholscher ericholscher merged commit c051b16 into readthedocs:master Aug 7, 2019
@saadmk11 saadmk11 deleted the update-build-details branch August 7, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants