Merge pull request #6034 from saadmk11/update-build-details

Do not show wipe version message on build details page for External versions

Author: ericholscher

readthedocs/builds/models.py

@@ -341,6 +341,11 @@ def identifier_friendly(self):
     def is_editable(self):
         return self.type == BRANCH
 
+    @property
+    def supports_wipe(self):
+        """Return True if version is not external."""
+        return not self.type == EXTERNAL
+
     def get_subdomain_url(self):
         private = self.privacy_level == PRIVATE
         return self.project.get_docs_url(

readthedocs/rtd_tests/tests/test_version.py

@@ -66,3 +66,9 @@ def test_commit_name_for_latest_version(self):
 
     def test_commit_name_for_external_version(self):
         self.assertEqual(self.external_version.commit_name, self.external_version.identifier)
+
+    def test_version_does_not_support_wipe(self):
+        self.assertFalse(self.external_version.supports_wipe)
+
+    def test_version_supports_wipe(self):
+        self.assertTrue(self.branch_version.supports_wipe)

readthedocs/templates/builds/build_detail.html

@@ -122,7 +122,7 @@
     </div>
 
     {% if request.user|is_admin:project %}
-      {% if not build.success and build.commands.count < 4 %}
+      {% if not build.success and build.commands.count < 4 and build.version.supports_wipe %}
         <div class="build-ideas">
           <p>
             {% url 'wipe_version' build.version.project.slug build.version.slug as wipe_url %}