Skip to content

Improve error message for invalid submodule URLs #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

Improve error message for invalid submodule URLs #5957

merged 1 commit into from
Jul 19, 2019

Conversation

pranay414
Copy link
Contributor

Fixes #5937

stsewd
stsewd approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stsewd stsewd requested a review from a team July 18, 2019 22:40
@stsewd stsewd merged commit 3806cbb into readthedocs:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve msg error for submodules with invalid url schemas
3 participants
@pranay414 @ericholscher @stsewd