Skip to content

Improve msg error for submodules with invalid url schemas #5937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Jul 16, 2019 · 2 comments · Fixed by #5957
Closed

Improve msg error for submodules with invalid url schemas #5937

stsewd opened this issue Jul 16, 2019 · 2 comments · Fixed by #5957
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Jul 16, 2019

We only support http schemas, but the error message isn't clear about that. Here is a good suggestion: #5928 (comment)
@stsewd stsewd added Good First Issue Good for new contributors Improvement Minor improvement to code labels Jul 16, 2019
@pranay414
Copy link
Contributor

@stsewd I would like to work on this.

@saadmk11
Copy link
Member

@pranay414 Sure, Go Ahead! 👍

@pranay414 pranay414 mentioned this issue Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error message for invalid submodule URLs pranay414/readthedocs.org
3 participants
@stsewd @pranay414 @saadmk11