Skip to content

Move python_interpreter out of the config object #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move python_interpreter out of the config object #5411

wants to merge 1 commit into from

Conversation

agarwalrounak
Copy link
Contributor

Fixes #4343

@agarwalrounak
Move python_interpreter out of the config object
b549b69 
Move python_interpreter out of the config object
@agarwalrounak agarwalrounak mentioned this pull request Mar 7, 2019
Merged
@stsewd stsewd added the PR: work in progress Pull request is not ready for full review label Mar 28, 2019
stsewd
stsewd requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but we mean to move this to a helper method and replace the call as needed. Current tests are failing.

@stale
Copy link

stale bot commented May 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label May 12, 2019
@stale stale bot closed this May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd requested changes

Assignees
No one assigned
Labels
PR: work in progress Pull request is not ready for full review Status: stale Issue will be considered inactive soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move python_interpreter out of the config object.
2 participants
@agarwalrounak @stsewd