Skip to content

Move python_interpreter out of the config object. #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Jul 9, 2018 · 11 comments
Closed

Move python_interpreter out of the config object. #4343

stsewd opened this issue Jul 9, 2018 · 11 comments
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Jul 9, 2018

The config object has a python_interpreter property, which just concatenates a string, this can be moved to a function.

Ref to #4298 (comment)

@stsewd stsewd added the Improvement Minor improvement to code label Jul 9, 2018
@humitos humitos added this to the YAML File Completion milestone Jul 24, 2018
@dojutsu-user
Copy link
Member

@stsewd
Is this still open? I would like to take this issue up.
If yes, what according to you can be the name of the function?

@stsewd
Copy link
Member Author

stsewd commented Oct 31, 2018

Yes, it's still open, and actually I was waiting to finish the changes related to all the config file before going for this one.

@dojutsu-user
Copy link
Member

okay, that means this issue needs to wait a little, right?

@stsewd
Copy link
Member Author

stsewd commented Oct 31, 2018

Yeah, I mean we could start now, but it would cause some conflicts on some big PRs, anyway, not sure how deep would be this change, it may be very simple, but just in case. I'll let you know when we are safe to fix this

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
@stsewd stsewd added the Good First Issue Good for new contributors label Mar 1, 2019
@rshrc
Copy link
Contributor

rshrc commented Mar 1, 2019

screenshot from 2019-03-01 19-59-05

So this is already done?

@aditya-prayaga
Copy link

Hi I am Aditya. Is this still on to do or someone else is working?

@dojutsu-user
Copy link
Member

@rshrc @Aditya-369
This issue is still valid.

@agarwalrounak
Copy link
Contributor

Hi @Aditya-369, I am working on this issue. I am so sorry that I forgot to comment here the same.

@aditya-prayaga
Copy link

@agarwalrounak cool no problem.

@stsewd
Copy link
Member Author

stsewd commented May 7, 2020

I'm closing this, there were a lot of changes since this issue. python_interpreter is fine just there.

@stsewd stsewd closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants