Skip to content

Don't depend on specific data when catching exception #5326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Don't depend on specific data when catching exception #5326

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e70f73b
Don't depend or specific data
stsewd Feb 20, 2019
8376557
Add comment
stsewd Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readthedocs/projects/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,8 @@ def run(
'stack': True,
'tags': {
'build': build_pk,
'project': self.project.slug,
'version': self.version.slug,
'project': self.project.slug if self.project else None,
'version': self.version.slug if self.version else None,
},
},
)
Expand Down