Don't depend on specific data when catching exception #5326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are catching all exceptions here, but we are depending on self.project and self.version be correctly returned from the api. This doesn't always happens, and it's raising another error.
stsewd
commented
Feb 20, 2019
stsewd
changed the title
humitos
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are catching all exceptions here,
but we are depending on self.project and self.version
be correctly returned from the api.
This doesn't always happen, and it's raising another error.
We should catch more specific errors, but we are not seeing those errors bc of this error (hope that makes sense 👀 )
Sentry issue https://sentry.io/organizations/read-the-docs/issues/754905187/?project=148442&referrer=RegressionActivityEmail&statsPeriod=14d