Remove sphinx static and template dir #5039
Conversation
This is already handled by the rtd-sphinx-extension. We don't override the template from rtd (readthedocs#1946)
| @@ -37,7 +37,6 @@ if not 'html_static_path' in globals(): | |||
| html_static_path = [] | |||
| if os.path.exists('_static'): | |||
| html_static_path.append('_static') | |||
There was a problem hiding this comment.
I'm tempted to remove this whole block too
|
Tested it locally, no more warnings, everything is working. |
There was a problem hiding this comment.
I don't have all this flow in my mind, but before merging this we would be sure that,
- this is not something needed for the corporate site
- we don't need to override any Sphinx template never again :)
- by removing this, we still do have another way to override a Sphinx template (using our extension for example)
After checking these three steps, I think we are fine to merge (didn't review the PR yet, though).
I didn't find any reference in .com
I think we should stay away of modifying the theme inside the rtd, all that should be managed by the extension, that way is less likely to break in case we update sphinx, or users can pin to a compatible version of the extension. |
|
OK! I suppose we are fine, then. |
This is already handled by the rtd-sphinx-extension.
We don't override the template from rtd (#1946)
Half solves #5029