Remove overriding of Sphinx templates #1946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This wasn't triaged, is it WIP or complete? Do we need the JS piece here? |
ericholscher
added
the
PR: work in progress
7 tasks
ericholscher
added
PR: ready for review
and removed
PR: work in progress
agjohnson
force-pushed
the
remove-layout-html
branch
from
0e95476 to
7ac2986
Compare
agjohnson
added a commit
that referenced
this pull request
Feb 28, 2016
Remove overriding of Sphinx templates
stsewd
added a commit
to stsewd/readthedocs.org
that referenced
this pull request
Dec 26, 2018
This is already handled by the rtd-sphinx-extension. We don't override the template from rtd (readthedocs#1946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now doing this more reliably with Sphinx-level insertion.
Depends on readthedocs/readthedocs-sphinx-ext#13
This moves this logic from the
layout.htmlto overriding it in Sphinx.This will append it to the
bodyof the Sphinx context,which is what is added to pages when doing the template rendering.
This moves execution of our javascript to the bottom of the block,
which means we'll also need to remove the insertion of our JS until below this also.
Refs #152