-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Surface "abandoned" state on projects in UI #4995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface "abandoned" state on projects in UI #4995
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4995 +/- ##
==========================================
+ Coverage 76.94% 76.96% +0.01%
==========================================
Files 158 158
Lines 10020 10035 +15
Branches 1258 1258
==========================================
+ Hits 7710 7723 +13
+ Misses 1981 1978 -3
- Partials 329 334 +5
|
@agjohnson |
Great, this is looking good so far! I didn't do a full review, we'll hopefully get to full review of this shortly, but there might be a delay in review here as this is off our roadmap. I gave a really quick glance and this seems to be replicating our notification system. You should move the email/on site notifications to use this system instead of using django pieces directly. |
@agjohnson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do a full review of this, but tried to give some feedback regarding the notification system and an issue about changing the slug directly.
I closed and reopend the PR for the travis to restart. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still valid bot. |
It seems that this PR is getting stale over and over again because we haven't had the time to review it. @rtfd/core we should try to take it a look or close it for now if we feel that it's too much outside of our roadmap at this point. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Issue #3382
-abandoned
to slugProject.is_abandoned