Surface "abandoned" state on projects in UI #3382

ericholscher · 2017-12-08T14:57:11Z

We now have an inactive project policy: http://docs.readthedocs.io/en/latest/abandoned-projects.html

We should:

Integrate a public facing "inactive" indicator into the RTD dashboard for projects that qualify

stsewd · 2018-02-15T03:25:36Z

I think we can develop this as two features.

Marking a doc as inactive/abandoned

With this a project that meets the policy requirements for abandoned projects gets marked as inactive/abandoned, this is visible for everyone.

And probably we may want to be able to mark a project as protected (on the django admin panel only), so in a special case this project never gets marked as inactive/abandoned. A special case could be: the author requesting this, for historical reasons, our algorithm is wrong or is a false positive.

Communicating to the users

I have several ideas for this...

We can run a cronjob and send a warning email to the owner of the project if her/his project is marked as abandoned.

A user wants the project name (from the inactive one), she/he fills a form with some details, the owner of the inactive project receives an email with a warning and the request of the other user. The request can be sent no more than once every time and if a user already sent a request and other wants to do the same, she/he needs to wait a time before sending it.

After the owner is warned several times and no action is taken for reactivate the project, the project name gets released. This is done changing the project name to a random one or {user-name}-inactive-{number}?

If the owner wants to release the project name, she/he can change the name (slug) manually or just delete the project and the user who sent the request gets notified.

Conclusion

I think with this solution all the process gets simplified and is automatic. And also the interaction between the users is minimal (almost none).

bansalnitish · 2018-02-27T22:31:15Z

Hi @stsewd, I would like to work on this! Can you please get me started!

stsewd · 2018-02-28T05:22:35Z

@bansalnitish I think is better to confirm if this is the way the core maintainers want implemented this feature. But you can also help by adding some feedback from my current proposal or maybe adding another.

ericholscher · 2018-02-28T05:28:27Z

I think we shouldn't automatically email/remove abandoned projects. I also think showing abandoned projects is lower priority. People who want a namespace are highly motivated, and will email us, so we should focus on executing that part first.

I think we should keep it light weight in terms of implementation so this isn't a lot to maintain. Perhaps just an admin-only button that says "email project owner with our abandoned project email" as a start, which sends an email from a template that we have in the repo.

Here is the email I sent last time as a start:

Hi,

We've had a request from one of our users for the project name {name} on Read the Docs. You are the current owner, and we wanted to reach out to you in accordance with our Abandoned Project policy (http://docs.readthedocs.io/en/latest/abandoned-projects.html).

Since this is a fork of the existing owners project, {name}, you must show us the additional work that has been done in order to keep the new project name, that is different than the existing version of the project.

Please reply to this email either allowing or disallowing the transfer of the name on Read the Docs within 6 weeks, otherwise we will take the action of *initiating the transfer to a new owner* by default.

Cheers,
Eric

ericholscher · 2018-02-28T05:29:45Z

At the end of the 6 week period, I renamed the project to {name}-abandoned, but I'm not 100% sure that's the correct thing to do.

ericholscher · 2018-02-28T05:31:23Z

I guess the primary thing I want to balance is the amount of work to build this, when it doesn't happen very often, with standardizing the execution. We could even just have a template in the docs, and not automate it within the software, as it has only happened a couple times so far.

stsewd · 2018-02-28T05:39:53Z

@ericholscher so suggesting a template for sending an email to [email protected] would be fine. I like the idea of keeping it simple for now.

bansalnitish · 2018-02-28T18:43:53Z

I am trying something simple for the start as suggested by @ericholscher and @stsewd.
I will submit a PR soon for the same and then we can discuss and make it better!

ericholscher · 2018-03-01T03:53:18Z

Yea, another simple addition would be to have a query that specified "abandoned", and have a small message on the project page. I'm all for keeping things simple to start.

agjohnson · 2018-03-08T17:44:02Z

I agree on keeping it simple if this is a feature we need, but I don't agree this is a feature we need though.

I do have a few problems with our plan so far:

The biggest problem with our plan so far is we haven't saved any steps. Would-be abandoned projects will start in an active state. The UI to email us or the owner will only be shown to users once the project is marked as abandoned though. This still requires a user to reach out to and admin and start the process of confirming the project is abandoned. It's only after 6 weeks that we can finally change the status to abandoned. At that point, however, the original user would claim the namespace. There's no need for an additional email at this point, and the UI for contacting the owner will never show
We aren't going to be proactive about marking projects as abandoned, so adding UI forms probably doesn't make sense
I think adding user -> user contact is adding too much complexity for what will be a very infrequently used feature

Things we do need:

An admin function that sends an email notifying the project owner that their project is potentially abandoned. Ask they respond in 6 weeks or their project will be moved
An admin function that sets the project as abandoned: it marks Project.is_abandoned, it changes the slug to {project}-abandoned, and it sends an email notifying the user of the change and a link to the new project/doc pages.
We're not good at keeping track of when we've contacted users and when the 6 week period is up. I'm not sure we need a feature to track this, it seems unnecessary. It should be part of the process, we can create a trello card and assign it 6mo in the future.
Add a UI piece for projects that have been determined to be abandoned. This should be a sidebar item on the project detail page: State: This project is abandoned or something similar

Yea, another simple addition would be to have a query that specified "abandoned", and have a small message on the project page

I dislike the message pattern, we have too many patterns for this floating around.

bansalnitish · 2018-03-08T18:05:42Z

Hi @agjohnson, the PR which I have issued contains the points:

To mark a project as abandoned
Admin only option to send mail to project owner
Tests for checking that only an admin is allowed to send email

The PR misses the following points:

Abandoned project state as a sidebar item on project detail page.
Changing the project slug to {project}-abandoned and notifying the user about that.

I want to know whether I should update the PR to match all the missing requirements.

agjohnson · 2018-03-08T20:43:09Z

@bansalnitish This issue is still in a design decision phase, we'll have some more guidance once we've come to some harder conclusions here.

I looked at the PR you started, but it has a few patterns I think we want to avoid:

Automating is_abandonded -- projects that don't build within a year aren't necessarily abandoned, perhaps just unmaintained. We want to act as an archive in this case, not promote transferring the namespace.
Surfacing sending email as a user feature. Above I discuss making this an admin feature -- that is, a django site admin feature, not part of the RTD UI

Hold off on making changes for now, as the requirements will likely change. I'll have some more specific feedback after that will hopefully clear up some questions.

bansalnitish · 2018-03-08T21:03:36Z

Sure @agjohnson, I will wait for the design decision to be made and then make the appropriate changes 🎉

agjohnson · 2018-06-08T20:46:10Z

I'm going to unblock this. I think the feature we actually need here is:

Djano site admin functions for sending an email to project owners that their namespace has been requested
Djano site admin function for marking a project as abandoned (Adds -abandoned to slug, marks Project.is_abandoned
Project detail sidebar piece that states project is abandoned.

In this feature, we don't want:

User to user email
Automating abandoned state
Email on the project forms

Unfortunately, I think your PR is mostly invalidated with these changes -- and there doesn't seem to be admin functions (django site admin functions that is) for any of this. So I'll close your current PR, but leave the branch around for reference. I'd suggest starting with a new PR for this work.

dojutsu-user · 2018-12-13T09:14:36Z

I am working on it.
Will submit a PR soon.

stale · 2019-01-27T09:56:02Z