Skip to content

Add help_text in the form for adopting a project #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2018
Merged

Add help_text in the form for adopting a project #4781

merged 1 commit into from
Oct 31, 2018

Conversation

dojutsu-user
Copy link
Member

Fixes #4777

@dojutsu-user
Copy link
Member Author

@stsewd Please review

stsewd
stsewd reviewed Oct 18, 2018
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd left the approve to someone with more english experience to see if the message is right

@dojutsu-user
Copy link
Member Author

@stsewd Thanks.
Also, as @humitos pointed out in comment #431004142, it is not enough for the user to understand as to what must be entered in the field, so are there any suggestions on this?

@ericholscher
Copy link
Member

This is at least an improvement. We can fix it up later.

@ericholscher ericholscher merged commit dedcaee into readthedocs:master Oct 31, 2018
@dojutsu-user dojutsu-user deleted the add-help-text-adopting-project branch December 12, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dojutsu-user @ericholscher @stsewd