Make form for adopting a project a ChoiceField

[dojutsu-user]

This is the form for adopting projects for Gold Members.

Currently the input field does not specify any idea about what to enter.
Although, the project's slug is need to be enter, but it is written nowhere which creates confusion and the user ends up entering the project's name which gives an error.

This issue was discussed in the comments #427135794, #427137725 and #427139109

[dojutsu-user]

@stsewd Will adding the help_text would be enough?

[humitos]

That field should probably be a ChoiceField where the user can only select the available options (I'm assuming that the User can only adopt projects where he is a maintainer --but I'm not 100% sure, you will need to check the code to know that)

[dojutsu-user]

https://github.com/rtfd/readthedocs.org/blob/df85fefc5f59c7a00bcc1ffe23965efe75e8c895/readthedocs/gold/views.py#L108-L110

@humitos from the code, it seems that the user can adopt any project.

[humitos]

Mmm... OK. It doesn't make too much sense to me, since it's a weird case to want to support a project that you are not involved to.

So, if we want to keep this behavior, my solution of the ChoiceField doesn't fit here.

Another different approach, that we don't have in any other place I think, would be to use a field with autocomplete --not sure if we want that, though. Probably, no.

I'd say that for now, the help_text is the first step, but it doesn't solve the whole problem anyway.

[dojutsu-user]

@humitos yeahh, help_text won't solve whole problem, but it atleast gives the idea/hint that the project's name is not to be entered here.

[ericholscher]

I'm +1 on adding it as a ChoiceField -- I think the current implementation wasn't a design decision. If someone needs to adopt a project they don't own, we can handle that as a support issue.

[dojutsu-user]

@ericholscher So, can i start working on this?

[ericholscher]

Sure!

[dojutsu-user]

@ericholscher
I have made a PR, can you please review it.

[ericholscher]

Fixed in #4841