Skip to content

Use validate_dict for more accurate error messages #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2018
Merged

Use validate_dict for more accurate error messages #4617

merged 1 commit into from
Sep 7, 2018

Conversation

ba11b0y
Copy link
Contributor

@ba11b0y ba11b0y commented Sep 7, 2018

Fixes #4530

@ba11b0y ba11b0y force-pushed the refactor/validate-dict branch from 714c9bc to d823e3d Compare September 7, 2018 11:36
stsewd
stsewd approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@agjohnson
Copy link
Contributor

Thanks for the contribution @invinciblycool ! 🎉

@agjohnson agjohnson merged commit 3501ca0 into readthedocs:master Sep 7, 2018
@ba11b0y
Copy link
Contributor Author

ba11b0y commented Sep 7, 2018

RTD has been a great help for me so thought of giving back to it. Looking forward to contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ba11b0y @agjohnson @stsewd