Skip to content

Change validation message #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Aug 16, 2018 · 3 comments
Closed

Change validation message #4530

stsewd opened this issue Aug 16, 2018 · 3 comments
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Aug 16, 2018

This line contains a wrong error message

https://github.com/rtfd/readthedocs.org/blob/79032b53b0aa75bce4d4a522c7f4771db730aa6c/readthedocs/config/config.py#L448-L452

should be changed to a more accurate one, or even better, use the new validator validate_dict as we do in other places

https://github.com/rtfd/readthedocs.org/blob/79032b53b0aa75bce4d4a522c7f4771db730aa6c/readthedocs/config/config.py#L624-L625

Ref to #4456 (comment)
@stsewd stsewd added Good First Issue Good for new contributors Improvement Minor improvement to code labels Aug 16, 2018
@stsewd stsewd mentioned this issue Aug 22, 2018
Merged
@srikant-ch5
Copy link
Contributor

Hi @stsewd can I work on this issue?

@stsewd
Copy link
Member Author

stsewd commented Sep 1, 2018

Sure, go ahead!

@ba11b0y ba11b0y mentioned this issue Sep 7, 2018
Merged
@RichardLitt
Copy link
Member

@Sriks123 Just wanted to point out that @invinciblycool has provided a fix for this! Might want to find another issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RichardLitt @stsewd @srikant-ch5