Skip to content

projects: don't explode trying to update UpdateDocsTaskStep state #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2018
Merged

projects: don't explode trying to update UpdateDocsTaskStep state #4485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions readthedocs/projects/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ def __init__(self, build_env=None, python_env=None, config=None,
if config is not None:
self.config = config
self.task = task
self.setup_env = None

def _log(self, msg):
log.info(LOG_TEMPLATE
Expand Down Expand Up @@ -355,12 +356,13 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
},
},
)
self.setup_env.failure = BuildEnvironmentError(
BuildEnvironmentError.GENERIC_WITH_BUILD_ID.format(
build_id=build_pk,
if self.setup_env is not None:
self.setup_env.failure = BuildEnvironmentError(
BuildEnvironmentError.GENERIC_WITH_BUILD_ID.format(
build_id=build_pk,
)
)
)
self.setup_env.update_build(BUILD_STATE_FINISHED)
self.setup_env.update_build(BUILD_STATE_FINISHED)
return False
else:
# No exceptions in the setup step, catch unhandled errors in the
Expand All @@ -379,12 +381,13 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
},
},
)
self.build_env.failure = BuildEnvironmentError(
BuildEnvironmentError.GENERIC_WITH_BUILD_ID.format(
build_id=build_pk,
if self.build_env is not None:
self.build_env.failure = BuildEnvironmentError(
BuildEnvironmentError.GENERIC_WITH_BUILD_ID.format(
build_id=build_pk,
)
)
)
self.build_env.update_build(BUILD_STATE_FINISHED)
self.build_env.update_build(BUILD_STATE_FINISHED)
return False

return True
Expand Down