projects: don't explode trying to update UpdateDocsTaskStep state #4485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
reviewed
Aug 7, 2018
There was a problem hiding this comment.
Thanks!
I found this while working on another issue and wrote a comment in this PR: #3864
In that PR, I mentioned that this happens for the self.setup_env but also a couple of lines below with self.build_env. It may worth to add the same checking there also.
If we don't have it because setup_env hasn't been called yet.
Traceback (most recent call last):
File "/readthedocs/projects/tasks.py", line 313, in run
self.version = self.get_version(self.project, version_pk)
File "/readthedocs/projects/tasks.py", line 84, in get_version
version_data = api_v2.version(version_pk).get()
File "/lib/python3.5/site-packages/slumber/__init__.py", line 155, in get
resp = self._request("GET", params=kwargs)
File "/lib/python3.5/site-packages/slumber/__init__.py", line 101, in _request
raise exception_class("Client Error %s: %s" % (resp.status_code, url), response=resp, content=resp.content)
slumber.exceptions.HttpNotFoundError: Client Error 404: http://localhost:8002/api/v2/version/868/
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/docsitalia/management/commands/rebuild_projects.py", line 33, in handle
task.run(version.project.pk, version_pk=version.pk, build_pk=build.pk)
File "/readthedocs/projects/tasks.py", line 332, in run
build_id=build_pk,
AttributeError: 'UpdateDocsTaskStep' object has no attribute 'setup_env'
While at it do the same for build_env that may be not set if run_build
fail early.
xrmx
force-pushed
the
dontassumebuildsetupenvupstream
branch
from
4be391d to
ac37f53
Compare
|
Update the PR to check also for build_env. |
|
Looks good. I think we need to think through this more, but 👍 on having the short-term fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception is raised before run_setup has been called we try to update the setup_env that is not here.