[Fix #2457] Implement exact match search #4292
Conversation
| @@ -20,7 +20,7 @@ def es_index(): | |||
|
|
|||
|
|
|||
| @pytest.fixture(autouse=True) | |||
| def all_projects(es_index, mock_processed_json): | |||
| def all_projects(es_index, mock_processed_json, db): | |||
There was a problem hiding this comment.
This doesn't appear to be used. Is it necessary?
There was a problem hiding this comment.
Its actually a fixture which need to injected for db access. whether you use or not, if any fixture has dependency to db fixture, that means the fixture has access to database.
| If query is `Foo Bar` then the result should be as following order: | ||
|
|
||
| - Where both `Foo Bar` is present | ||
| - Where `Foo` or `Bar` is present |
There was a problem hiding this comment.
Is the thought process that the first example -- both "foo" and "bar" are present -- will rank more highly than the second?
There was a problem hiding this comment.
Yes. It will have higher in rank as its more relevant
|
|
||
| # Need to search for both 'AND' and 'OR' operations | ||
| # The score of AND should be higher as it comes first | ||
| for operator in ['AND', 'OR']: |
There was a problem hiding this comment.
Do we need to boost the AND in some way, or will it automatically sort higher?
There was a problem hiding this comment.
AND matched index will surely have higher score as it satisfies both of the query.
It describes better: https://www.elastic.co/guide/en/elasticsearch/guide/current/bool-query.html#CO60-1
Or we can add boost value to the query explecitly!
There was a problem hiding this comment.
Let's leave it for now, and we can boost it later if we want.
[Fix readthedocs#2457] Implement exact match search
[Fix readthedocs#2457] Implement exact match search
Fix #2457
This PR implements searching exact phrase by using
""quoted text.(eg:"foo bar")It also rewrite the search functionality as there will be more relavant result by using both
ANDandORoperator.ANDoperator has higher priority than theORoperator.Like search with
Foo Bar(without quote) will match all the documents which have eitherFooorBar, but the pages which haveFooandBarboth, will be higher in index. So user will first see the relavant results, then see other results wich maybe also helpful for them.I have used bool query to combine both of the query. Elasticsearch The Definative Guide helped mostly to understand the thing. The paragraph in
elasticsearch-dsldocs is also helpful.@ericholscher r?