Skip to content

Recognize search phrases/multiple words as AND, not OR #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barbara-sfx opened this issue Oct 12, 2016 · 9 comments
Closed

Recognize search phrases/multiple words as AND, not OR #2457

barbara-sfx opened this issue Oct 12, 2016 · 9 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@barbara-sfx
Copy link
Contributor

Details

I'm not sure if this is an issue or a feature request.

  • Project URL: docs.signalfx.com
  • Build URL (if applicable):
  • Read the Docs username (if applicable):

Step:
Search for "metric proxy" (including the quotes)

Actual Result

All docs containing either or both words are returned. We have the word "metric" on many many pages, so these results really don't help.

Expected Result

Ideal: Only pages containing the exact phrase "metric proxy" are returned.
Better than now but not ideal: Only pages with both words are returned

In general, if a search phrase has multiple words, without quotes, I think this should be interpreted as a boolean AND, so only pages containing both words should be returned.

@humitos humitos added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Mar 9, 2017
@humitos humitos added this to the Search improvements milestone Mar 23, 2018
@austin-plixer
Copy link

Our company is looking for this feature request as well. It would be very helpful to our readers to search a phrase.

Even if that meant wrapping the search string with quotes as a workaround, it would greatly improve the search feature.

@ericholscher
Copy link
Member

ericholscher commented Jun 15, 2018

I'd like to get this as one of the next steps in our Summer of Code project (https://github.com/orgs/rtfd/projects/3). Having the ability to search with quotes and other common "google style" search queries would be a really good improvement for our search.

@safwanrahman safwanrahman self-assigned this Jun 19, 2018
@ericholscher
Copy link
Member

So, this feature should:

  • Allow searching of exact terms ("run the tests" and not return results that just mention tests)
  • It should search in a case insensitive manner ("Run the Tests" should return run the tests)

@barbara-sfx
Copy link
Contributor Author

Can linking to a heading above the search term rather than just the top of the doc also be part of the summer of code? (Your link to projects above is 404 so I can't see what's already there.)

@safwanrahman
Copy link
Member

@barbara-sfx The project has been made public. You will be able to access it now.

@barbara-sfx
Copy link
Contributor Author

Thanks @safwanrahman. How would I create a feature request for you guys to prioritize and determine if/when you might address it? Ideally, clicking on a search result would go to the actual matching sentence. I said heading (in my comment above) because I thought that would be more do-able. But navigating to the actual sentence or paragraph is actually what I would expect to see when I click a search result.

@safwanrahman
Copy link
Member

@barbara-sfx You can create new issue for any feature you would like to get implemented. For taking our attention, you can mention me in the issue, so I can look into it and assign proper flag.
Its better to keep this issue focused on the topic

@safwanrahman safwanrahman added the Accepted Accepted issue on our roadmap label Jun 21, 2018
ericholscher added a commit that referenced this issue Jun 26, 2018
[Fix #2457] Implement exact match search
@safwanrahman
Copy link
Member

It has been fixed by #4292
Thanks a lot @barbara-sfx for the issue!
Wishing for the best to get it deployed.

@safwanrahman
Copy link
Member

@austin-plixer It has been fixed in the search_upgrade branch. We hope to get it deployed within couple of weeks.

safwanrahman pushed a commit to safwanrahman/readthedocs.org that referenced this issue Jul 16, 2018
safwanrahman pushed a commit to safwanrahman/readthedocs.org that referenced this issue Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

5 participants