-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Written guide for elasticsearch local #3881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
$ ps -p 1 | ||
|
||
**Running Elasticsearch with SysV init** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave how to run Elasticsearch to users for several reasons:
-
There are multiple init systems and it would be nice to not maintain these commands in our documentation.
-
People may want to add their choice of init system to the documentation and that would also increase the maintenance work.
-
They also can use it without using any init systems and package managers:
$ wget https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.3.8.tar.gz $ tar xf elasticsearch-1.3.8.tar.gz $ cd elasticsearch-1.3.8/ $ ./bin/elasticsearch
I wonder if we should document this method instead since it makes installing and running Elasticsearch without having to deal with different init systems, package managers, and distros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First I thought of writing exactly the same as mentioned by you (i.e directly downloading the tar file), it was previously covered in #3852 . As the said method has an advantage of not having to maintain the init systems, we have a disadvantage of having to start the elasticsearch server each time we need to run our RTD server locally.
4. Index the data available at RTD database | ||
------------------------------------------- | ||
|
||
In order to search through the RTD database, you need to index it into the elasticsearch index.:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[...] index.::
will be converted to HTML as
[...] index.:
I'd drop the "." character.
|
||
After installing java, verify the installation by,:: | ||
|
||
$ java -version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style nit: Please don't use tab characters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean $ sign?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't clear in my earlier comment. I meant don't use the \t
character to indent code. See the following comparison:
# With using tab:
$ java -version
# Without tabs, used four spaces instead:
$ java -version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed as mentioned 👍
1. Installing Java | ||
------------------ | ||
|
||
Elasticsearch requires JAVA 8 or later. Use `Oracle official documentation <http://www.oracle.com/technetwork/java/javase/downloads/index.html>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style nit: I don't know which one is correct (Java vs. JAVA) but please use the same style in the documentation.
Enabling Elasticsearch on the local server | ||
========================================== | ||
|
||
Read the Docs has been using Elasticsearch which is a platform for distributed search and analysis of data in real time. To enable the search feature on your local installation, you need to install the elasticsearch locally and run the Elastic server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style nit: Please wrap lines at 80 characters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajujha373 @berkerpeksag actually, rtd doesn't use that style of wrapping all lines to 80 characters, here are the guidelines for writing docs https://docs.readthedocs.io/en/latest/docs.html#content. Note that this was recently added.
Enabling Elasticsearch on the local server | ||
========================================== | ||
|
||
Read the Docs has been using Elasticsearch which is a platform for distributed search and analysis of data in real time. To enable the search feature on your local installation, you need to install the elasticsearch locally and run the Elastic server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the elasticsearch" -> can "the" be dropped here?
2. Downloading and installing Elasticsearch | ||
------------------------------------------- | ||
|
||
Elasticsearch can be downloaded directly from elastic.co in zip, tar.gz, deb, or rpm packages. For Ubuntu, it's best to use the deb (Debian) package which will install everything you need to run Elasticsearch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop the "in zip, tar.gz, deb, or rpm packages" part to make it brief.
Elasticsearch can be downloaded directly from elastic.co in zip, tar.gz, deb, or rpm packages. For Ubuntu, it's best to use the deb (Debian) package which will install everything you need to run Elasticsearch. | ||
|
||
RTD currently uses elasticsearch 1.x which can be easily downloaded and installed from the `Official Website | ||
<https://www.elastic.co/downloads/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the Official Website -> from elastic.co
RTD currently uses elasticsearch 1.x which can be easily downloaded and installed from the `Official Website | ||
<https://www.elastic.co/downloads/>`_. | ||
|
||
1. First download the deb package version 1.3.8 from this `Link <https://www.elastic.co/downloads/past-releases/elasticsearch-1-3-8>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd merge the first item with the paragraph above. Since we need to install a specific version of Elasticsearch, we don't need to mention the generic downloads page. We can just link to the download page of 1.3.8.
1. First download the deb package version 1.3.8 from this `Link <https://www.elastic.co/downloads/past-releases/elasticsearch-1-3-8>`_. | ||
|
||
2. Install the downloaded package by following command | ||
``$ sudo apt install .{path-to-downloaded-file}/elasticsearch-1.3.8.deb`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use a code block instead of ``...``:
2. [...] command::
$ sudo apt install .{path-to-downloaded-file}/elasticsearch-1.3.8.deb
Oh, I forgot to mention that this new document should be linked in http://docs.readthedocs.io/en/latest/install.html (see the fourth note) |
that sounds really motivating @berkerpeksag thank you :) |
Hi @berkerpeksag is there anything more to be done in this PR? |
@rajujha373 did you address all reviews comments or am I seeing an outdated version of your PR for some reason? For example, the new document didn't linked in |
@@ -1,3 +1,5 @@ | |||
.. _running-elasticsearch-locally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to add this if you use the doc
role :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, I was checking out how to link the files ... Forgot to delete it .. 😀
Hi @rajujha373, Thanks for the writeup. |
This is a good change. I'm going to merge it to get the data published, and it can be improved over time. |
Build on top of #3881 and put docs in custom_installs.
With reference to #3803 and in replacement of #3852 .
I have created a new PR because of following reasons: