Skip to content

Written guide for elasticsearch #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

irkartik
Copy link
Contributor

with reference to #3803

@@ -0,0 +1,84 @@
Enabling Elasticsearch on the local server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Title Case for the title


Installation has been mainly divided into following steps.

1. Installing Java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't better to link to official resources for this step? So we don't need to maintain this at the future or write it for every OS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @stsewd , I will do the required changes

OpenJDK 64-Bit Server VM (build 25.151-b12, mixed mode)


2. Downloading and installing Elasticsearch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, linking to the official installation guide could be better

@xrmx
Copy link
Contributor

xrmx commented Mar 27, 2018

@rajujha373 Have you tried the elasticsearch ppa? Am not sure you need to add a ppa for openjdk 8 on a currently supported distribution.

@irkartik
Copy link
Contributor Author

@xrmx I have not tried elasticsearch ppa, I just downloaded the package and ran the server manually. I guess I am going to give it a try.


RTD currently uses elasticsearch 1.x which can be easily downloaded and installed from the official website (http://elastic.co).

Download it in a directory parallel to where the readthedocs.org project has been stored.::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strictly necessary? What about the people that install it with a package manager? (also I think this step is visible on the elastic search official guide)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some research, I found out that there are various ways to start the elastic server and the steps I have written works as well but requires a bit more work than the installation with package manager.
I guess i'm gonna re-write the guide for installing and setting up elastic server via package manager. :)

3. Running Elasticsearch from command line
------------------------------------------

Goto elasticsearch home directory.::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, maybe just saying that executing the server with elasticsearch is better here.

@irkartik
Copy link
Contributor Author

Hey @stsewd I have re-written the guide for installation of elasticsearch in local system. The code has been a mess currently but once you finalise the changes, I can create a new PR if you wish.
Do notify me if any changes are necessary :)

@stsewd
Copy link
Member

stsewd commented Mar 29, 2018

@rajujha373 not sure why the diff shows unrelated files, also always create a new branch when making changes (I see you did it on your master branch).

@irkartik
Copy link
Contributor Author

Yeah I too noticed it after making the changes. I'll keep this in mind next time :) @stsewd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants