-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
#3779: Remove autocomplete js from templates #3805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, except for the removal of the ID's.
@@ -63,7 +37,7 @@ <h2 class="quiet">Search in this project:</h2> | |||
<div class="wide-search-bar-wrapper clearfix"> | |||
<form action="." method="GET"> | |||
<div class="text-input-wrapper"> | |||
<input type="text" name="q" value="{{ query|default_if_none:"" }}" id="id_elastic_project_search"> | |||
<input type="text" name="q" value="{{ query|default_if_none:"" }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These ID's should stay.
{% block content %} | ||
|
||
<!-- BEGIN search form --> | ||
<div class="wide-search-bar"> | ||
<div class="wide-search-bar-wrapper clearfix"> | ||
<form action="." method="GET"> | ||
<div class="text-input-wrapper"> | ||
<input type="text" name="q" value="{{ query }}" autocomplete="off" id="id_site_search_2"> | ||
<input type="text" name="q" value="{{ query }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. This ID should stay.
@ericholscher DId the required changes. :) |
with reference to Issue #3779 . Removed autocomplete js from the templates.