Skip to content

#3779: Remove autocomplete js from templates #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2018

Conversation

irkartik
Copy link
Contributor

with reference to Issue #3779 . Removed autocomplete js from the templates.

@agjohnson agjohnson added this to the Cleanup milestone Mar 15, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, except for the removal of the ID's.

@@ -63,7 +37,7 @@ <h2 class="quiet">Search in this project:</h2>
<div class="wide-search-bar-wrapper clearfix">
<form action="." method="GET">
<div class="text-input-wrapper">
<input type="text" name="q" value="{{ query|default_if_none:"" }}" id="id_elastic_project_search">
<input type="text" name="q" value="{{ query|default_if_none:"" }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ID's should stay.

{% block content %}

<!-- BEGIN search form -->
<div class="wide-search-bar">
<div class="wide-search-bar-wrapper clearfix">
<form action="." method="GET">
<div class="text-input-wrapper">
<input type="text" name="q" value="{{ query }}" autocomplete="off" id="id_site_search_2">
<input type="text" name="q" value="{{ query }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This ID should stay.

@irkartik
Copy link
Contributor Author

irkartik commented May 1, 2018

@ericholscher DId the required changes. :)

@ericholscher ericholscher merged commit 40ece34 into readthedocs:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants