Remove autocomplete js from templates

[stsewd]

On 16f3527 the autocomplete js was removed (was not working), there are others templates with this js that should be removed too.

This https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/core/static-src/core/js/autocomplete.js should be removed too?

Also this should be removed? https://github.com/rtfd/readthedocs.org/blob/master/media/css/autocomplete.css

Files founded:

• https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/templates/projects/project_comments_settings.html#L43
• https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/templates/search/elastic_project_search.html#L19
• https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/templates/core/widesearchbar.html#L24

[humitos]

Doing a simple grep I found other places where this is used. For example, at https://github.com/rtfd/readthedocs.org/blob/8f2d59cdcdee0050feece79465d1a6c5c903ecf5/readthedocs/templates/search/elastic_project_search.html

So, we will probably do more grep here to find other places also and decide if they should stay or should be removed.

Grepping by autocomplete and/or ui-autocomplete will be useful. There are some tests for the autocomplete and some other templates that I just saw at a quick look.

[stsewd]

@humitos I found 3 files (one is a comment, probably removing it would be a clean up 😄) And also there is this function https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/projects/views/public.py#L199 is really used this feature on the site? Or is abandoned?

ps: I update the description with the new files

[irkartik]

@stsewd @humitos shall I take up this issue?

[stsewd]

@rajujha373 let's wait to @humitos confirm us what is to be done with some files.

[irkartik]

Sure @stsewd :)

[humitos]

I never touched the autosearch code, so to answer your question I would need to do probably exactly the same that you would need to do:

• check where that code is used
• think if it's correct that should be used there
• check against readthedocs.org if that code in that place works properly
• decide if it should stay or should be removed
• write some tests (if needed)
• remove the autocomplete code

Summarizing, "I have no idea" but left some steps that you can follow to research and answer that question by yourself :)

I would love to see a PR comming in with this ;)

Hope it helps.

[stsewd]

This was solved in #3805