Skip to content

#3757: Split requirements/pip.txt #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

irkartik
Copy link
Contributor

@irkartik irkartik commented Mar 13, 2018

Hi @humitos , I have made the requested changes in pull request #3767 here which references the issue #3757

  1. Separated requirements/pip.txt and requirements/local-docs-build.txt
  2. Included requirements/local-docs-build.txt into requirements/pip.txt since it's used to parse the YAML file.
  3. Matched the versions installed by default under readthedocs/doc-builder/python_environments.py with the versions in requirements/

@stsewd
Copy link
Member

stsewd commented May 17, 2018

@rajujha373 would you like to rebase and see the current packages that has been updated recently? (maybe you can take a look to the requirements files of the curren master)

@irkartik
Copy link
Contributor Author

Yeah, @stsewd I would love to do so. Will get back when done. Thanks :)

@agjohnson agjohnson added PR: work in progress Pull request is not ready for full review and removed PR: ready for review labels Jun 8, 2018
@agjohnson agjohnson added this to the Development improvements milestone Jun 8, 2018
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a few more pieces on this, and also needs a rebase or master needs to be merged in.

django==1.9.12
six==1.10.0
future==0.16.0
readthedocs-build<2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a docs only dependency

Pygments==2.2.0
mkdocs==0.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a docs only dependency, I'm mostly certain it's not even a dependency at all. You'll need to test this more.

@@ -1,16 +1,14 @@
#LOCAL-DOCS-BUILD PACKAGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: this isn't a package, it's a requirements file.

@agjohnson agjohnson added the Needed: patch A pull request is required label Jun 8, 2018
@ericholscher
Copy link
Member

Closing this, as it's quite out of date and hasn't been updated. Feel free to open another PR with this work against the latest requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: patch A pull request is required PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants